[Webkit-unassigned] [Bug 130466] [GTK][CMake] CMake build fails to link TestNetscapePlugIn

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 3 17:15:38 PST 2016


Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #227199|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #7 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 227199
  --> https://bugs.webkit.org/attachment.cgi?id=227199

View in context: https://bugs.webkit.org/attachment.cgi?id=227199&action=review

Sorry this went unreviewed for so long. :(

>> Source/cmake/OptionsGTK.cmake:169
>> +
> Why is this necessary? CMake already looks for X11 libraries by default.

We wound up adding this earlier this year, for compatibility with newer CMake, but guarded by if (ENABLE_X11_TARGET). Anyway, it doesn't need to be added anymore, because we already have done so....

> Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:41
> +    ${X11_X11_LIB}

And DRT is no longer used by the GTK+ port, so I think this patch is obsolete.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160104/3b2f8341/attachment.html>

More information about the webkit-unassigned mailing list