<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][CMake] CMake build fails to link TestNetscapePlugIn"
href="https://bugs.webkit.org/show_bug.cgi?id=130466">bug 130466</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #227199 Flags</td>
<td>review?, commit-queue?
</td>
<td>review-, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][CMake] CMake build fails to link TestNetscapePlugIn"
href="https://bugs.webkit.org/show_bug.cgi?id=130466#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][CMake] CMake build fails to link TestNetscapePlugIn"
href="https://bugs.webkit.org/show_bug.cgi?id=130466">bug 130466</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=227199&action=diff" name="attach_227199" title="Patch">attachment 227199</a> <a href="attachment.cgi?id=227199&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=227199&action=review">https://bugs.webkit.org/attachment.cgi?id=227199&action=review</a>
Sorry this went unreviewed for so long. :(
<span class="quote">>> Source/cmake/OptionsGTK.cmake:169
>> +
>
> Why is this necessary? CMake already looks for X11 libraries by default.</span >
We wound up adding this earlier this year, for compatibility with newer CMake, but guarded by if (ENABLE_X11_TARGET). Anyway, it doesn't need to be added anymore, because we already have done so....
<span class="quote">> Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:41
> + ${X11_X11_LIB}</span >
And DRT is no longer used by the GTK+ port, so I think this patch is obsolete.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>