[Webkit-unassigned] [Bug 90734] [GStreamer] usec rounding is wrong during accurate seeking

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90734

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #238352|review?                     |review-
              Flags|                            |

--- Comment #24 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 238352
  --> https://bugs.webkit.org/attachment.cgi?id=238352
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238352&action=review

The code changes in this patch look fine, but I don't understand the test.

> LayoutTests/media/video-frame-accurate-seek.html:8
> +        <p>Test that setting currentTime is frame-accurate. Four videos below should be showing up, The first three at frames 12, 13, and 14. The last video should display at 6.0272 seconds.</p>

The -> the

> LayoutTests/platform/gtk/media/video-frame-accurate-seek-expected.txt:9
> +          text run at (0,17) width 356: "and 14. The last video should display at 6.0272 seconds."

It seems like something is wrong with this test. The expected result for the first three videos shows 12, 13, and 15, but the test says it's expected to show 12, 13, and 14. The last video displays 6.01 seconds, not 6.0272 or 6.03.

> LayoutTests/platform/mac/TestExpectations:1392
> +webkit.org/b/90734 media/video-frame-accurate-seek.html [ Failure ]

I think you should file new bugs for the EFL and Mac rebaselines, else they probably won't happen if you add an expectation to hide the failures.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160102/d4d6a798/attachment.html>