<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] usec rounding is wrong during accurate seeking"
href="https://bugs.webkit.org/show_bug.cgi?id=90734">bug 90734</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #238352 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] usec rounding is wrong during accurate seeking"
href="https://bugs.webkit.org/show_bug.cgi?id=90734#c24">Comment # 24</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] usec rounding is wrong during accurate seeking"
href="https://bugs.webkit.org/show_bug.cgi?id=90734">bug 90734</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=238352&action=diff" name="attach_238352" title="Patch">attachment 238352</a> <a href="attachment.cgi?id=238352&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=238352&action=review">https://bugs.webkit.org/attachment.cgi?id=238352&action=review</a>
The code changes in this patch look fine, but I don't understand the test.
<span class="quote">> LayoutTests/media/video-frame-accurate-seek.html:8
> + <p>Test that setting currentTime is frame-accurate. Four videos below should be showing up, The first three at frames 12, 13, and 14. The last video should display at 6.0272 seconds.</p></span >
The -> the
<span class="quote">> LayoutTests/platform/gtk/media/video-frame-accurate-seek-expected.txt:9
> + text run at (0,17) width 356: "and 14. The last video should display at 6.0272 seconds."</span >
It seems like something is wrong with this test. The expected result for the first three videos shows 12, 13, and 15, but the test says it's expected to show 12, 13, and 14. The last video displays 6.01 seconds, not 6.0272 or 6.03.
<span class="quote">> LayoutTests/platform/mac/TestExpectations:1392
> +webkit.org/b/90734 media/video-frame-accurate-seek.html [ Failure ]</span >
I think you should file new bugs for the EFL and Mac rebaselines, else they probably won't happen if you add an expectation to hide the failures.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>