[Webkit-unassigned] [Bug 117232] [Threaded Compositor] Apply scroll-offset and scale in Widget window coordinate.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 2 08:56:02 PST 2016


Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #206080|                            |review+
              Flags|                            |

--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 206080
  --> https://bugs.webkit.org/attachment.cgi?id=206080

View in context: https://bugs.webkit.org/attachment.cgi?id=206080&action=review

Nevermind, you can just close the bug if it's obsolete.

> Source/WebCore/platform/Widget.cpp:145
> +IntRect Widget::convertFromRootToContainingWindow(const Widget* widget, const IntRect& rect)

These functions ought to take a const Widget& rather than a const Widget*, since it will crash if widget is ever null. (That should be changed in a follow-up patch.)

> Source/WebCore/platform/Widget.cpp:148
> +    const ScrollView* scrollView = widget->root();

scrollView can never be null here?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160102/2a790416/attachment.html>

More information about the webkit-unassigned mailing list