<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - [Threaded Compositor] Apply scroll-offset and scale in Widget window coordinate."
href="https://bugs.webkit.org/show_bug.cgi?id=117232">bug 117232</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #206080 Flags</td>
<td>
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - [Threaded Compositor] Apply scroll-offset and scale in Widget window coordinate."
href="https://bugs.webkit.org/show_bug.cgi?id=117232#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - [Threaded Compositor] Apply scroll-offset and scale in Widget window coordinate."
href="https://bugs.webkit.org/show_bug.cgi?id=117232">bug 117232</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=206080&action=diff" name="attach_206080" title="Patch">attachment 206080</a> <a href="attachment.cgi?id=206080&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=206080&action=review">https://bugs.webkit.org/attachment.cgi?id=206080&action=review</a>
Nevermind, you can just close the bug if it's obsolete.
<span class="quote">> Source/WebCore/platform/Widget.cpp:145
> +IntRect Widget::convertFromRootToContainingWindow(const Widget* widget, const IntRect& rect)</span >
These functions ought to take a const Widget& rather than a const Widget*, since it will crash if widget is ever null. (That should be changed in a follow-up patch.)
<span class="quote">> Source/WebCore/platform/Widget.cpp:148
> + const ScrollView* scrollView = widget->root();</span >
scrollView can never be null here?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>