[Webkit-unassigned] [Bug 154796] [cmake] Allow using FindGLIB in case glib is optional dependency.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154796

Gwang Yoon Hwang <yoon at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yoon at igalia.com

--- Comment #4 from Gwang Yoon Hwang <yoon at igalia.com> ---
I faced below linking error after this change in Fedora 22 using build-webkit script.


[1145/6100] Linking CXX shared library lib/libjavascriptcoregtk-4.0.so.18.3.4
FAILED: : && /usr/libexec/icecc/bin/clang++  -fPIC -std=c++11 -fcolor-diagnostics -Qunused-arguments -O3 -DNDEBUG -fno-exceptions -fno-strict-aliasing -fno-rtti  -Wl,--no-undefined  -L/home/yoon/workspace/WebKitGtk/WebKitBuild/DependenciesGTK/Root/lib  -fuse-ld=gold -Wl,--disable-new-dtags -fuse-ld=gold -Wl,--disable-new-dtags -shared -Wl,-soname,libjavascriptcoregtk-4.0.so.18 -o lib/libjavascriptcoregtk-4.0.so.18.3.4 @CMakeFiles/JavaScriptCore.rsp  && :
lib/libWTFGTK.a(lib/../Source/WTF/wtf/CMakeFiles/WTF.dir/glib/GRefPtr.cpp.o):../../Source/WTF/wtf/glib/GRefPtr.cpp:function _GClosure* WTF::refGPtr<_GClosure>(_GClosure*): error: undefined reference to 'g_closure_ref'
lib/libWTFGTK.a(lib/../Source/WTF/wtf/CMakeFiles/WTF.dir/glib/GRefPtr.cpp.o):../../Source/WTF/wtf/glib/GRefPtr.cpp:function void WTF::derefGPtr<_GClosure>(_GClosure*): error: undefined reference to 'g_closure_unref'
clang-3.8: error: linker command failed with exit code 1 (use -v to see invocation)

There is some notable difference between before and after this change at the CMakeCache.txt in the WebKitBuild/Release/.
Before this change, WTF_LIB_DEPENDS explicitly includes libglib-2.0.so, it is disappeared after.

FYI, Here is the diff of the CMakeCache.txt
http://pastebin.com/jS8iVb5t

Is it intended behavior?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160229/baac9732/attachment-0001.html>