<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:yoon@igalia.com" title="Gwang Yoon Hwang <yoon@igalia.com>"> <span class="fn">Gwang Yoon Hwang</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [cmake] Allow using FindGLIB in case glib is optional dependency."
href="https://bugs.webkit.org/show_bug.cgi?id=154796">bug 154796</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>yoon@igalia.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [cmake] Allow using FindGLIB in case glib is optional dependency."
href="https://bugs.webkit.org/show_bug.cgi?id=154796#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [cmake] Allow using FindGLIB in case glib is optional dependency."
href="https://bugs.webkit.org/show_bug.cgi?id=154796">bug 154796</a>
from <span class="vcard"><a class="email" href="mailto:yoon@igalia.com" title="Gwang Yoon Hwang <yoon@igalia.com>"> <span class="fn">Gwang Yoon Hwang</span></a>
</span></b>
<pre>I faced below linking error after this change in Fedora 22 using build-webkit script.
[1145/6100] Linking CXX shared library lib/libjavascriptcoregtk-4.0.so.18.3.4
FAILED: : && /usr/libexec/icecc/bin/clang++ -fPIC -std=c++11 -fcolor-diagnostics -Qunused-arguments -O3 -DNDEBUG -fno-exceptions -fno-strict-aliasing -fno-rtti -Wl,--no-undefined -L/home/yoon/workspace/WebKitGtk/WebKitBuild/DependenciesGTK/Root/lib -fuse-ld=gold -Wl,--disable-new-dtags -fuse-ld=gold -Wl,--disable-new-dtags -shared -Wl,-soname,libjavascriptcoregtk-4.0.so.18 -o lib/libjavascriptcoregtk-4.0.so.18.3.4 @CMakeFiles/JavaScriptCore.rsp && :
lib/libWTFGTK.a(lib/../Source/WTF/wtf/CMakeFiles/WTF.dir/glib/GRefPtr.cpp.o):../../Source/WTF/wtf/glib/GRefPtr.cpp:function _GClosure* WTF::refGPtr<_GClosure>(_GClosure*): error: undefined reference to 'g_closure_ref'
lib/libWTFGTK.a(lib/../Source/WTF/wtf/CMakeFiles/WTF.dir/glib/GRefPtr.cpp.o):../../Source/WTF/wtf/glib/GRefPtr.cpp:function void WTF::derefGPtr<_GClosure>(_GClosure*): error: undefined reference to 'g_closure_unref'
clang-3.8: error: linker command failed with exit code 1 (use -v to see invocation)
There is some notable difference between before and after this change at the CMakeCache.txt in the WebKitBuild/Release/.
Before this change, WTF_LIB_DEPENDS explicitly includes libglib-2.0.so, it is disappeared after.
FYI, Here is the diff of the CMakeCache.txt
<a href="http://pastebin.com/jS8iVb5t">http://pastebin.com/jS8iVb5t</a>
Is it intended behavior?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>