[Webkit-unassigned] [Bug 153230] Network cache: old pages returned by disk cache on history navigation after session is restored

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 25 09:07:38 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=153230

--- Comment #43 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 271879
  --> https://bugs.webkit.org/attachment.cgi?id=271879
Updated patch

Sorry, still not a huge fan of the complexity this adds. This seems intrusive and a bit complicated for what it does.

Would the following work?
1. We don't add a new load type (we already have too many)
2. We had a boolean flag to WebCore::HistoryItem to distinguish that the HistoryItem was restored from a previous session
3. We check this new WebCore::HistoryItem flag in FrameLoader::loadDifferentDocumentItem() to choose the right cache policy without requiring a new load type
4. We reset this flag right after it is read in FrameLoader::loadDifferentDocumentItem().

Let me know what you think.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160225/7966dcac/attachment-0001.html>


More information about the webkit-unassigned mailing list