<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Network cache: old pages returned by disk cache on history navigation after session is restored"
href="https://bugs.webkit.org/show_bug.cgi?id=153230#c43">Comment # 43</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Network cache: old pages returned by disk cache on history navigation after session is restored"
href="https://bugs.webkit.org/show_bug.cgi?id=153230">bug 153230</a>
from <span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=271879&action=diff" name="attach_271879" title="Updated patch">attachment 271879</a> <a href="attachment.cgi?id=271879&action=edit" title="Updated patch">[details]</a></span>
Updated patch
Sorry, still not a huge fan of the complexity this adds. This seems intrusive and a bit complicated for what it does.
Would the following work?
1. We don't add a new load type (we already have too many)
2. We had a boolean flag to WebCore::HistoryItem to distinguish that the HistoryItem was restored from a previous session
3. We check this new WebCore::HistoryItem flag in FrameLoader::loadDifferentDocumentItem() to choose the right cache policy without requiring a new load type
4. We reset this flag right after it is read in FrameLoader::loadDifferentDocumentItem().
Let me know what you think.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>