[Webkit-unassigned] [Bug 154628] Use IndentTextOrNot instead of passing isFirstLine/shouldIndentText as bool.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 24 09:55:30 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=154628

--- Comment #4 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 272083
  --> https://bugs.webkit.org/attachment.cgi?id=272083
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272083&action=review

> Source/WebCore/rendering/RenderBlock.h:125
> +    LayoutUnit availableLogicalWidthForLineInRegion(LayoutUnit position, IndentTextOrNot shouldIndentText, RenderRegion* region, LayoutUnit logicalHeight = 0) const

I dislike names with "OrNot." How about ShouldIndentText? ShouldIndent? IndentionRequired?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160224/d0aba5c6/attachment-0001.html>


More information about the webkit-unassigned mailing list