[Webkit-unassigned] [Bug 154628] Use IndentTextOrNot instead of passing isFirstLine/shouldIndentText as bool.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154628

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #272083|review?                     |review+
              Flags|                            |

--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 272083
  --> https://bugs.webkit.org/attachment.cgi?id=272083
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272083&action=review

> Source/WebCore/rendering/RootInlineBox.cpp:724
> +        LayoutUnit nextLeft = blockFlow().logicalLeftOffsetForLine(nextTop, DoNotIndentText);
> +        LayoutUnit nextRight = blockFlow().logicalRightOffsetForLine(nextTop, DoNotIndentText);
> +        LayoutUnit newLeft = blockFlow().logicalLeftOffsetForLine(selectionBottom, DoNotIndentText);
> +        LayoutUnit newRight = blockFlow().logicalRightOffsetForLine(selectionBottom, DoNotIndentText);

Seems like DoNot is much more common; maybe make it a default parameter?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160224/526e63e3/attachment.html>