[Webkit-unassigned] [Bug 154535] Workaround for ICE in GCC 4.8 appeared in r196846.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154535

--- Comment #14 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to comment #11)
> Comment on attachment 271923 [details]
> Patch
> 
> Ok to unbreak you and because equalIgnoringASCIICase() has a literal taking
> an override. However, I wish we understood the problem a bit better.

To be clear, it's a GCC bug causing some obsolete version of GCC to crash (ICE = internal compiler error), and this modification is a workaround for that crash. It'd be reasonable to accept the patch (it's a one-liner that adds support for a new compiler) or reject it (it's a workaround for a compiler we technically don't support anymore), I'd err on the side of accept... which you did.

(In reply to comment #8)
> I believe it calls
> 
> template<unsigned length> bool equalLettersIgnoringASCIICase(const
> StringImpl&, const char (&lowercaseLetters)[length]);

Wow! This is quite esoteric C++, the only time I ever saw this syntax was in a trivia question... array parameters are normally just pointers, but for templates it's not necessarily true!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160222/77b5cd24/attachment.html>