<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Workaround for ICE in GCC 4.8 appeared in r196846."
href="https://bugs.webkit.org/show_bug.cgi?id=154535#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Workaround for ICE in GCC 4.8 appeared in r196846."
href="https://bugs.webkit.org/show_bug.cgi?id=154535">bug 154535</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=154535#c11">comment #11</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=271923&action=diff" name="attach_271923" title="Patch">attachment 271923</a> <a href="attachment.cgi?id=271923&action=edit" title="Patch">[details]</a></span>
> Patch
>
> Ok to unbreak you and because equalIgnoringASCIICase() has a literal taking
> an override. However, I wish we understood the problem a bit better.</span >
To be clear, it's a GCC bug causing some obsolete version of GCC to crash (ICE = internal compiler error), and this modification is a workaround for that crash. It'd be reasonable to accept the patch (it's a one-liner that adds support for a new compiler) or reject it (it's a workaround for a compiler we technically don't support anymore), I'd err on the side of accept... which you did.
(In reply to <a href="show_bug.cgi?id=154535#c8">comment #8</a>)
<span class="quote">> I believe it calls
>
> template<unsigned length> bool equalLettersIgnoringASCIICase(const
> StringImpl&, const char (&lowercaseLetters)[length]);</span >
Wow! This is quite esoteric C++, the only time I ever saw this syntax was in a trivia question... array parameters are normally just pointers, but for templates it's not necessarily true!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>