[Webkit-unassigned] [Bug 154512] Added new port JSCOnly.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154512

--- Comment #3 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 271880
  --> https://bugs.webkit.org/attachment.cgi?id=271880
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271880&action=review

>> Source/cmake/OptionsJSCOnly.cmake:22
>> +if (CMAKE_MAJOR_VERSION LESS 3)
> 
> Nowadays I think everyone will have CMake 3 or higher... since this is only a convenience for developers (makes the build stop on error) we can probably get rid of it from OptionsGTK.cmake, and probably don't need it for this new port either.

FWIW, I'm routinely using 2.8.12.2, but it won't be a dealbreaker if 3.0 becomes required.
Another option is to split cmake < 3 support into separate file and include it into both places.

>> Source/cmake/OptionsJSCOnly.cmake:43
>> +# You can build JavaScriptCore as a static library if you specify it as STATIC
> 
> Did you consider making this a public build option?
> 
> WEBKIT_OPTION_BEGIN()
> WEBKIT_OPTION_DEFINE(ENABLE_STATIC_JSC "Whether to build JavaScriptCore as a static library." PUBLIC OFF)
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTL_JIT PUBLIC ON)
> WEBKIT_OPTION_END()
> 
> if (ENABLE_STATIC_JSC)
>     set(JavaScriptCore_LIBRARY_TYPE STATIC)
> endif ()

Will do it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160221/f3fe0866/attachment-0001.html>