<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Added new port JSCOnly."
href="https://bugs.webkit.org/show_bug.cgi?id=154512#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Added new port JSCOnly."
href="https://bugs.webkit.org/show_bug.cgi?id=154512">bug 154512</a>
from <span class="vcard"><a class="email" href="mailto:annulen@yandex.ru" title="Konstantin Tokarev <annulen@yandex.ru>"> <span class="fn">Konstantin Tokarev</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=271880&action=diff" name="attach_271880" title="Patch">attachment 271880</a> <a href="attachment.cgi?id=271880&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=271880&action=review">https://bugs.webkit.org/attachment.cgi?id=271880&action=review</a>
<span class="quote">>> Source/cmake/OptionsJSCOnly.cmake:22
>> +if (CMAKE_MAJOR_VERSION LESS 3)
>
> Nowadays I think everyone will have CMake 3 or higher... since this is only a convenience for developers (makes the build stop on error) we can probably get rid of it from OptionsGTK.cmake, and probably don't need it for this new port either.</span >
FWIW, I'm routinely using 2.8.12.2, but it won't be a dealbreaker if 3.0 becomes required.
Another option is to split cmake < 3 support into separate file and include it into both places.
<span class="quote">>> Source/cmake/OptionsJSCOnly.cmake:43
>> +# You can build JavaScriptCore as a static library if you specify it as STATIC
>
> Did you consider making this a public build option?
>
> WEBKIT_OPTION_BEGIN()
> WEBKIT_OPTION_DEFINE(ENABLE_STATIC_JSC "Whether to build JavaScriptCore as a static library." PUBLIC OFF)
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTL_JIT PUBLIC ON)
> WEBKIT_OPTION_END()
>
> if (ENABLE_STATIC_JSC)
> set(JavaScriptCore_LIBRARY_TYPE STATIC)
> endif ()</span >
Will do it.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>