[Webkit-unassigned] [Bug 149060] [ThreadedCompositor] Scrolling artifacts on accelerated subframes
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 16 03:43:08 PST 2016
https://bugs.webkit.org/show_bug.cgi?id=149060
Zan Dobersek <zan at falconsigh.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #261001|review+ |review-
Flags| |
--- Comment #3 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 261001
--> https://bugs.webkit.org/attachment.cgi?id=261001
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=261001&action=review
This needs some clarification. Yoon should chip in as well.
> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:126
> void ThreadedCoordinatedLayerTreeHost::scrollNonCompositedContents(const WebCore::IntRect& rect)
The parameter is now unused.
> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:-128
> - m_compositor->scrollTo(rect.location());
After removing this, ThreadedCompositor::scrollTo() is not called anymore. Do we still need it?
> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:-242
> - if (m_lastScrollPosition != roundedIntPoint(rect.location())) {
> - m_lastScrollPosition = roundedIntPoint(rect.location());
> -
> - if (!m_webPage->corePage()->mainFrame().view()->useFixedLayout())
> - m_webPage->corePage()->mainFrame().view()->notifyScrollPositionChanged(m_lastScrollPosition);
> - }
> -
> - if (m_lastScaleFactor != scale) {
> - m_lastScaleFactor = scale;
> - didScaleFactorChanged(m_lastScaleFactor, m_lastScrollPosition);
> - }
Same for m_lastScrollPosition and m_lastScaleFactor -- these are unused afterwards.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160216/73874f5b/attachment.html>
More information about the webkit-unassigned
mailing list