<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:zan@falconsigh.net" title="Zan Dobersek <zan@falconsigh.net>"> <span class="fn">Zan Dobersek</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [ThreadedCompositor] Scrolling artifacts on accelerated subframes"
href="https://bugs.webkit.org/show_bug.cgi?id=149060">bug 149060</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #261001 Flags</td>
<td>review+
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ThreadedCompositor] Scrolling artifacts on accelerated subframes"
href="https://bugs.webkit.org/show_bug.cgi?id=149060#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ThreadedCompositor] Scrolling artifacts on accelerated subframes"
href="https://bugs.webkit.org/show_bug.cgi?id=149060">bug 149060</a>
from <span class="vcard"><a class="email" href="mailto:zan@falconsigh.net" title="Zan Dobersek <zan@falconsigh.net>"> <span class="fn">Zan Dobersek</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=261001&action=diff" name="attach_261001" title="Patch">attachment 261001</a> <a href="attachment.cgi?id=261001&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=261001&action=review">https://bugs.webkit.org/attachment.cgi?id=261001&action=review</a>
This needs some clarification. Yoon should chip in as well.
<span class="quote">> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:126
> void ThreadedCoordinatedLayerTreeHost::scrollNonCompositedContents(const WebCore::IntRect& rect)</span >
The parameter is now unused.
<span class="quote">> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:-128
> - m_compositor->scrollTo(rect.location());</span >
After removing this, ThreadedCompositor::scrollTo() is not called anymore. Do we still need it?
<span class="quote">> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:-242
> - if (m_lastScrollPosition != roundedIntPoint(rect.location())) {
> - m_lastScrollPosition = roundedIntPoint(rect.location());
> -
> - if (!m_webPage->corePage()->mainFrame().view()->useFixedLayout())
> - m_webPage->corePage()->mainFrame().view()->notifyScrollPositionChanged(m_lastScrollPosition);
> - }
> -
> - if (m_lastScaleFactor != scale) {
> - m_lastScaleFactor = scale;
> - didScaleFactorChanged(m_lastScaleFactor, m_lastScrollPosition);
> - }</span >
Same for m_lastScrollPosition and m_lastScaleFactor -- these are unused afterwards.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>