[Webkit-unassigned] [Bug 154235] [GTK][GStreamer] ClearKey EME v1 decryption support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154235

--- Comment #20 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #19)
> Comment on attachment 271332 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=271332&action=review
> 
> >> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:108
> >> +    GRefPtr<GstElementFactory> clearKeyDecryptorFactory = gst_element_factory_find("webkitclearkey");
> > 
> > adoptGRef
> 
> #0  0x00007fb7b781d253 in _g_log_abort (breakpoint=1) at
> /home/phil/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.46.0/glib/
> gmessages.c:324
> #1  g_logv (log_domain=0x7fb7b7b41170 "GLib-GObject",
> log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>,
> args=args at entry=0x7fff59e44618)
>     at
> /home/phil/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.46.0/glib/
> gmessages.c:1081
> #2  0x00007fb7b781d3b2 in g_log (log_domain=log_domain at entry=0x7fb7b7b41170
> "GLib-GObject", log_level=log_level at entry=G_LOG_LEVEL_CRITICAL,
> format=format at entry=0x7fb7b788b786 "%s: assertion '%s' failed")
>     at
> /home/phil/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.46.0/glib/
> gmessages.c:1119
> #3  0x00007fb7b781d3d9 in g_return_if_fail_warning
> (log_domain=log_domain at entry=0x7fb7b7b41170 "GLib-GObject",
> pretty_function=pretty_function at entry=0x7fb7b7b44af0 <__func__.13475>
> "g_object_is_floating", 
>     expression=expression at entry=0x7fb7b7b4375a "G_IS_OBJECT (object)") at
> /home/phil/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.46.0/glib/
> gmessages.c:1128
> #4  0x00007fb7b7b1ed6c in g_object_is_floating (_object=0x0) at
> /home/phil/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.46.0/gobject/
> gobject.c:2815
> #5  0x00007fb7c48d6739 in WTF::adoptGRef<_GstElementFactory> (ptr=0x0) at
> ../../Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:167
> #6  0x00007fb7c48ecf74 in WebCore::registerWebKitGStreamerElements () at
> ../../Source/WebCore/platform/graphics/gstreamer/
> MediaPlayerPrivateGStreamerBase.cpp:108

This is a bug of GRefPtr<GstElementFactory> adoptGRef(GstElementFactory* ptr), the assert there is wrong, it should be:

ASSERT(!ptr || !g_object_is_floating(G_OBJECT(ptr)));

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160216/83fa7148/attachment.html>