<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][GStreamer] ClearKey EME v1 decryption support"
href="https://bugs.webkit.org/show_bug.cgi?id=154235#c20">Comment # 20</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][GStreamer] ClearKey EME v1 decryption support"
href="https://bugs.webkit.org/show_bug.cgi?id=154235">bug 154235</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=154235#c19">comment #19</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=271332&action=diff" name="attach_271332" title="patch">attachment 271332</a> <a href="attachment.cgi?id=271332&action=edit" title="patch">[details]</a></span>
> patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=271332&action=review">https://bugs.webkit.org/attachment.cgi?id=271332&action=review</a>
>
> >> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:108
> >> + GRefPtr<GstElementFactory> clearKeyDecryptorFactory = gst_element_factory_find("webkitclearkey");
> >
> > adoptGRef
>
> #0 0x00007fb7b781d253 in _g_log_abort (breakpoint=1) at
> /home/phil/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.46.0/glib/
> gmessages.c:324
> #1 g_logv (log_domain=0x7fb7b7b41170 "GLib-GObject",
> log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>,
> args=args@entry=0x7fff59e44618)
> at
> /home/phil/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.46.0/glib/
> gmessages.c:1081
> #2 0x00007fb7b781d3b2 in g_log (log_domain=log_domain@entry=0x7fb7b7b41170
> "GLib-GObject", log_level=log_level@entry=G_LOG_LEVEL_CRITICAL,
> format=format@entry=0x7fb7b788b786 "%s: assertion '%s' failed")
> at
> /home/phil/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.46.0/glib/
> gmessages.c:1119
> #3 0x00007fb7b781d3d9 in g_return_if_fail_warning
> (log_domain=log_domain@entry=0x7fb7b7b41170 "GLib-GObject",
> pretty_function=pretty_function@entry=0x7fb7b7b44af0 <__func__.13475>
> "g_object_is_floating",
> expression=expression@entry=0x7fb7b7b4375a "G_IS_OBJECT (object)") at
> /home/phil/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.46.0/glib/
> gmessages.c:1128
> #4 0x00007fb7b7b1ed6c in g_object_is_floating (_object=0x0) at
> /home/phil/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.46.0/gobject/
> gobject.c:2815
> #5 0x00007fb7c48d6739 in WTF::adoptGRef<_GstElementFactory> (ptr=0x0) at
> ../../Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:167
> #6 0x00007fb7c48ecf74 in WebCore::registerWebKitGStreamerElements () at
> ../../Source/WebCore/platform/graphics/gstreamer/
> MediaPlayerPrivateGStreamerBase.cpp:108</span >
This is a bug of GRefPtr<GstElementFactory> adoptGRef(GstElementFactory* ptr), the assert there is wrong, it should be:
ASSERT(!ptr || !g_object_is_floating(G_OBJECT(ptr)));</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>