[Webkit-unassigned] [Bug 154076] [GTK] Gardening for unexpected passes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154076

--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 270998
  --> https://bugs.webkit.org/attachment.cgi?id=270998
patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=270998&action=review

Hi, thanks for your patch, it's much appreciated.

I am a bit confused, though, since you add a cross-platform file, but only modify the GTK expectations. Is it not a GTK-specific failure? Why does the test pass on other platforms without that file?

> LayoutTests/ChangeLog:3
> +        [GTK] Gardening for unexpected passes.

Since you're actually fixing a test, I wouldn't call this "gardening" which we generally use to refer to only updating test expectations or rebaselining tests. Instead, I'd say something like "[GTK] Fix layout test imported/blink/compositing/squashing/squashing-reflection-disallowed.html"

> LayoutTests/platform/gtk/TestExpectations:2399
> +webkit.org/b/151267 imported/blink/compositing/squashing/squashing-reflection-disallowed.html [ ImageOnlyFailure Pass ]

If the test is passing now, you should just remove it from the expectations file. [ ImageOnlyFailure Pass ] is used to indicate a broken test that sometimes passes and sometimes fails (flaky test).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160210/de88b43e/attachment.html>