<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Gardening for unexpected passes"
href="https://bugs.webkit.org/show_bug.cgi?id=154076#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Gardening for unexpected passes"
href="https://bugs.webkit.org/show_bug.cgi?id=154076">bug 154076</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=270998&action=diff" name="attach_270998" title="patch v2">attachment 270998</a> <a href="attachment.cgi?id=270998&action=edit" title="patch v2">[details]</a></span>
patch v2
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=270998&action=review">https://bugs.webkit.org/attachment.cgi?id=270998&action=review</a>
Hi, thanks for your patch, it's much appreciated.
I am a bit confused, though, since you add a cross-platform file, but only modify the GTK expectations. Is it not a GTK-specific failure? Why does the test pass on other platforms without that file?
<span class="quote">> LayoutTests/ChangeLog:3
> + [GTK] Gardening for unexpected passes.</span >
Since you're actually fixing a test, I wouldn't call this "gardening" which we generally use to refer to only updating test expectations or rebaselining tests. Instead, I'd say something like "[GTK] Fix layout test imported/blink/compositing/squashing/squashing-reflection-disallowed.html"
<span class="quote">> LayoutTests/platform/gtk/TestExpectations:2399
> +webkit.org/b/151267 imported/blink/compositing/squashing/squashing-reflection-disallowed.html [ ImageOnlyFailure Pass ]</span >
If the test is passing now, you should just remove it from the expectations file. [ ImageOnlyFailure Pass ] is used to indicate a broken test that sometimes passes and sometimes fails (flaky test).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>