[Webkit-unassigned] [Bug 154074] [cmake] Consolidate CMake code related to image decoders.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154074

--- Comment #5 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 270993
  --> https://bugs.webkit.org/attachment.cgi?id=270993
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270993&action=review

>> Source/WebCore/ChangeLog:17
>> +        * ImageDecoders.cmake: Added.
> 
> I don't have a strong opinion either way, but I know we've talked about making the WebCore directory less cluttered.  I think it might be better to put this in WebCore/platform.

I was afraid that WebCore/platform it may be lost between variouse source files, but I will move it there if you feel WebCore is not appropriate.

Alternatively, there can be WebCore/cmake (though AFAIK such directories are usually created to store macros and other helper modules)

>> Source/WebCore/ImageDecoders.cmake:29
>> +if (JPEG_FOUND)
> 
> I think these should remain unconditional.  We should have a hard failure if these aren't found.

WinCairo does not use find_package for libjpeg and libpng, therefore repspective variables are empty. I thought it is not a good practice to append empty variables to the lists.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160210/f319bfea/attachment.html>