[Webkit-unassigned] [Bug 154074] [cmake] Consolidate CMake code related to image decoders.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154074

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #270993|review?, commit-queue?      |review-
              Flags|                            |

--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 270993
  --> https://bugs.webkit.org/attachment.cgi?id=270993
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270993&action=review

> Source/WebCore/ChangeLog:17
> +        * ImageDecoders.cmake: Added.

I don't have a strong opinion either way, but I know we've talked about making the WebCore directory less cluttered.  I think it might be better to put this in WebCore/platform.

> Source/WebCore/ImageDecoders.cmake:29
> +if (JPEG_FOUND)

I think these should remain unconditional.  We should have a hard failure if these aren't found.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160210/c5644671/attachment.html>