[Webkit-unassigned] [Bug 153939] AX: Implement word related text marker functions using TextIterator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153939

--- Comment #11 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 270803
  --> https://bugs.webkit.org/attachment.cgi?id=270803
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270803&action=review

> Source/WebCore/ChangeLog:10
> +        logics from previousBoundary and nextBoundary in VisibleUnits class.

... reused logic from ...

> Source/WebCore/accessibility/AXObjectCache.cpp:1554
> +    return AccessibilityObject::replacedNodeNeedsCharacter(node) || node->hasTagName(brTag);

do you need to worry that node is nullptr here

> Source/WebCore/editing/VisibleUnits.h:118
> +WEBCORE_EXPORT unsigned forwardSearchForBoundaryWithTextIterator(TextIterator&, Vector<UChar, 1024>&, unsigned, BoundarySearchFunction);

these probably don't need to be WEBCORE_EXPORT, since the only people using are within WebCore

> Tools/DumpRenderTree/AccessibilityUIElement.cpp:979
> +    AccessibilityTextMarker* marker = 0;

nullptr and ditto for everything below

> LayoutTests/accessibility/mac/text-marker-word-nav.html:14
> +Test Content<span id="target" contenteditable="true">editable is working.</span>

can you add a test for content that is <pre> with line breaks, and then some content with <br> inside

> LayoutTests/accessibility/mac/text-marker-word-nav.html:18
> +c <img src="#" aria-label="blah" style="background-color: #aaaaaa; width: 100px; height: 100px;">d

can you add a test for an <audio> or <video> element

> LayoutTests/accessibility/mac/text-marker-word-nav.html:24
> +巧克力是食物吗？

which language is this? 
can you also add arabic

> LayoutTests/accessibility/mac/text-marker-word-nav.html:78
> +        function advanceAndVerify(currentMarker, offset, obj) {

can you add a test that runs from the start of the document to the end and the back again in reverse with word markers. that way we get some coverage of bigger movements

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160209/fbf71e60/attachment.html>