<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Implement word related text marker functions using TextIterator"
href="https://bugs.webkit.org/show_bug.cgi?id=153939#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Implement word related text marker functions using TextIterator"
href="https://bugs.webkit.org/show_bug.cgi?id=153939">bug 153939</a>
from <span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=270803&action=diff" name="attach_270803" title="patch">attachment 270803</a> <a href="attachment.cgi?id=270803&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=270803&action=review">https://bugs.webkit.org/attachment.cgi?id=270803&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:10
> + logics from previousBoundary and nextBoundary in VisibleUnits class.</span >
... reused logic from ...
<span class="quote">> Source/WebCore/accessibility/AXObjectCache.cpp:1554
> + return AccessibilityObject::replacedNodeNeedsCharacter(node) || node->hasTagName(brTag);</span >
do you need to worry that node is nullptr here
<span class="quote">> Source/WebCore/editing/VisibleUnits.h:118
> +WEBCORE_EXPORT unsigned forwardSearchForBoundaryWithTextIterator(TextIterator&, Vector<UChar, 1024>&, unsigned, BoundarySearchFunction);</span >
these probably don't need to be WEBCORE_EXPORT, since the only people using are within WebCore
<span class="quote">> Tools/DumpRenderTree/AccessibilityUIElement.cpp:979
> + AccessibilityTextMarker* marker = 0;</span >
nullptr and ditto for everything below
<span class="quote">> LayoutTests/accessibility/mac/text-marker-word-nav.html:14
> +Test Content<span id="target" contenteditable="true">editable is working.</span></span >
can you add a test for content that is <pre> with line breaks, and then some content with <br> inside
<span class="quote">> LayoutTests/accessibility/mac/text-marker-word-nav.html:18
> +c <img src="#" aria-label="blah" style="background-color: #aaaaaa; width: 100px; height: 100px;">d</span >
can you add a test for an <audio> or <video> element
<span class="quote">> LayoutTests/accessibility/mac/text-marker-word-nav.html:24
> +å·§å
åæ¯é£ç©åï¼</span >
which language is this?
can you also add arabic
<span class="quote">> LayoutTests/accessibility/mac/text-marker-word-nav.html:78
> + function advanceAndVerify(currentMarker, offset, obj) {</span >
can you add a test that runs from the start of the document to the end and the back again in reverse with word markers. that way we get some coverage of bigger movements</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>