[Webkit-unassigned] [Bug 153951] "ref test hashes didn't match but diff passed" is useless, should not be logged

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153951

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.webkit.org/sho
                   |                            |w_bug.cgi?id=142632

--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Two of these are tracked in bug 142632, which I think is a real bug that needs to be fixed. Another known reason was bug 139884, which definitely needed to be discovered and fixed.

The best way to check the others is to edit single_test_runner.py so that it would report these tests as failing, and to manually compare the results. I think that the following should do it (untested):

-            if diff_result[0]:
-                failures.append(test_failures.FailureReftestMismatch(reference_filename))
-            else:
-                _log.warning("  %s -> ref test hashes didn't match but diff passed" % self._test_name)
+            failures.append(test_failures.FailureReftestMismatch(reference_filename))

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160207/10780954/attachment.html>