<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - "ref test hashes didn't match but diff passed" is useless, should not be logged"
href="https://bugs.webkit.org/show_bug.cgi?id=153951">bug 153951</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">See Also</td>
<td>
</td>
<td>https://bugs.webkit.org/show_bug.cgi?id=142632
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - "ref test hashes didn't match but diff passed" is useless, should not be logged"
href="https://bugs.webkit.org/show_bug.cgi?id=153951#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - "ref test hashes didn't match but diff passed" is useless, should not be logged"
href="https://bugs.webkit.org/show_bug.cgi?id=153951">bug 153951</a>
from <span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span></b>
<pre>Two of these are tracked in <a class="bz_bug_link
bz_status_NEW "
title="NEW - Some reftests get crazy snapshot sizes"
href="show_bug.cgi?id=142632">bug 142632</a>, which I think is a real bug that needs to be fixed. Another known reason was <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [Mac WK2] Test snapshots are 1600x1200 on Retina devices"
href="show_bug.cgi?id=139884">bug 139884</a>, which definitely needed to be discovered and fixed.
The best way to check the others is to edit single_test_runner.py so that it would report these tests as failing, and to manually compare the results. I think that the following should do it (untested):
- if diff_result[0]:
- failures.append(test_failures.FailureReftestMismatch(reference_filename))
- else:
- _log.warning(" %s -> ref test hashes didn't match but diff passed" % self._test_name)
+ failures.append(test_failures.FailureReftestMismatch(reference_filename))</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>