[Webkit-unassigned] [Bug 153230] Network cache: old pages returned by disk cache on history navigation after session is restored

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153230

--- Comment #23 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 270743
  --> https://bugs.webkit.org/attachment.cgi?id=270743
Try to fix mac builds

View in context: https://bugs.webkit.org/attachment.cgi?id=270743&action=review

I think Sam or Anders need to review this.

> Source/WebCore/ChangeLog:11
> +        policy cache to ensure it's revalidated by the disk cache if needed.

I would say "to ensure we do not use stale cached data in this case". As this seems to be the intent.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1199
> +    // iOS always want stale data for history navigation.

'wants'.

I don't quite get this comment because it is not just iOS, so does everyone else. The only case some platforms do not want stale data is for session restore (Which used to be considered as a history navigation but does not really have to).

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1218
> +    m_page->goToItem(*item, frameLoadTypeForBackForwardItem(backForwardItemID, FrameLoadType::Forward));

So we will use SessionRestoredBackForward on iOS even though this has nothing to do with session restore? This seems wrong.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1233
> +    m_page->goToItem(*item, frameLoadTypeForBackForwardItem(backForwardItemID, FrameLoadType::Back));

ditto.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1248
> +    m_page->goToItem(*item, frameLoadTypeForBackForwardItem(backForwardItemID, FrameLoadType::IndexedBackForward));

ditto, this is not only used for session restore.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160205/fa777ada/attachment-0001.html>