<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Network cache: old pages returned by disk cache on history navigation after session is restored"
href="https://bugs.webkit.org/show_bug.cgi?id=153230#c23">Comment # 23</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Network cache: old pages returned by disk cache on history navigation after session is restored"
href="https://bugs.webkit.org/show_bug.cgi?id=153230">bug 153230</a>
from <span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=270743&action=diff" name="attach_270743" title="Try to fix mac builds">attachment 270743</a> <a href="attachment.cgi?id=270743&action=edit" title="Try to fix mac builds">[details]</a></span>
Try to fix mac builds
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=270743&action=review">https://bugs.webkit.org/attachment.cgi?id=270743&action=review</a>
I think Sam or Anders need to review this.
<span class="quote">> Source/WebCore/ChangeLog:11
> + policy cache to ensure it's revalidated by the disk cache if needed.</span >
I would say "to ensure we do not use stale cached data in this case". As this seems to be the intent.
<span class="quote">> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1199
> + // iOS always want stale data for history navigation.</span >
'wants'.
I don't quite get this comment because it is not just iOS, so does everyone else. The only case some platforms do not want stale data is for session restore (Which used to be considered as a history navigation but does not really have to).
<span class="quote">> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1218
> + m_page->goToItem(*item, frameLoadTypeForBackForwardItem(backForwardItemID, FrameLoadType::Forward));</span >
So we will use SessionRestoredBackForward on iOS even though this has nothing to do with session restore? This seems wrong.
<span class="quote">> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1233
> + m_page->goToItem(*item, frameLoadTypeForBackForwardItem(backForwardItemID, FrameLoadType::Back));</span >
ditto.
<span class="quote">> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1248
> + m_page->goToItem(*item, frameLoadTypeForBackForwardItem(backForwardItemID, FrameLoadType::IndexedBackForward));</span >
ditto, this is not only used for session restore.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>