[Webkit-unassigned] [Bug 147602] [INTL] Implement Intl.NumberFormat.prototype.resolvedOptions ()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147602

--- Comment #32 from Sukolsak Sakshuwong <sukolsak at gmail.com> ---
(In reply to comment #31)
> > Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:194
> > +    m_locale = result.get(ASCIILiteral("locale"));
> 
> Since we are going to make an Identifier here, not a String, ASCIILiteral is
> not idea. Might ask Ben Poulain or some other JavaScriptCore experts what
> the preferred style is for this kind of thing.
> 
> > Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:197
> > +    m_numberingSystem = result.get(ASCIILiteral("nu"));
> 
> Ditto.

Could you please clarify? "result" is a HashMap<String, String>. So, I think this is fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160204/c9486060/attachment-0001.html>