<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [INTL] Implement Intl.NumberFormat.prototype.resolvedOptions ()"
href="https://bugs.webkit.org/show_bug.cgi?id=147602#c32">Comment # 32</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [INTL] Implement Intl.NumberFormat.prototype.resolvedOptions ()"
href="https://bugs.webkit.org/show_bug.cgi?id=147602">bug 147602</a>
from <span class="vcard"><a class="email" href="mailto:sukolsak@gmail.com" title="Sukolsak Sakshuwong <sukolsak@gmail.com>"> <span class="fn">Sukolsak Sakshuwong</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=147602#c31">comment #31</a>)
<span class="quote">> > Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:194
> > + m_locale = result.get(ASCIILiteral("locale"));
>
> Since we are going to make an Identifier here, not a String, ASCIILiteral is
> not idea. Might ask Ben Poulain or some other JavaScriptCore experts what
> the preferred style is for this kind of thing.
>
> > Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:197
> > + m_numberingSystem = result.get(ASCIILiteral("nu"));
>
> Ditto.</span >
Could you please clarify? "result" is a HashMap<String, String>. So, I think this is fine.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>