[Webkit-unassigned] [Bug 153818] Format revisions for display according to repository type

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153818

--- Comment #4 from Jason Marcell <jmarcell at apple.com> ---
(In reply to comment #2)
> Comment on attachment 270547 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=270547&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:131
> > +                revision = commit.revisionNumber.substr(0, 7);
> 
> Should there be a utility function with a helpful name for substr(0, 7)?

I started to write a utility function just for the Git part but then I went another route and made a more generic function called _formatRevisionForDisplay that handles both the Git and the Subversion part. I also noticed another section of the codebase where we were doing almost the exact same thing so it ended up being useful there as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160204/875d76a8/attachment.html>