<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Format revisions for display according to repository type"
href="https://bugs.webkit.org/show_bug.cgi?id=153818#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Format revisions for display according to repository type"
href="https://bugs.webkit.org/show_bug.cgi?id=153818">bug 153818</a>
from <span class="vcard"><a class="email" href="mailto:jmarcell@apple.com" title="Jason Marcell <jmarcell@apple.com>"> <span class="fn">Jason Marcell</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=153818#c2">comment #2</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=270547&action=diff" name="attach_270547" title="Patch">attachment 270547</a> <a href="attachment.cgi?id=270547&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=270547&action=review">https://bugs.webkit.org/attachment.cgi?id=270547&action=review</a>
>
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:131
> > + revision = commit.revisionNumber.substr(0, 7);
>
> Should there be a utility function with a helpful name for substr(0, 7)?</span >
I started to write a utility function just for the Git part but then I went another route and made a more generic function called _formatRevisionForDisplay that handles both the Git and the Subversion part. I also noticed another section of the codebase where we were doing almost the exact same thing so it ended up being useful there as well.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>