[Webkit-unassigned] [Bug 152345] Teach dashboard code to compare non-integer revisions.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152345

--- Comment #27 from Daniel Bates <dbates at webkit.org> ---
(In reply to comment #26)
> > [...]
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:82
> > +        var indexToBeLaterThan = this.indexOfRevision(revision);
> > +        function selectCommitsLaterThanRevision(commit, index, allCommits) {
> > +            return index > indexToBeLaterThan;
> > +        }
> > +        var commits = this._commitsOnBranch(branchName, selectCommitsLaterThanRevision.bind(this));
> > +        return commits;
> 
> Then we can implement this as:
> 
> [...]
> return this._commitsOnBranch(branchName, null, indexToBeLaterThan + 1);

err, I meant to write:

return this._commitsOnBranch(branchName, indexToBeLaterThan + 1);

> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:93
> > +        var indexOfFirstRevision = this.indexOfRevision(firstRevision);
> > +        var indexOfLastRevision = this.indexOfRevision(lastRevision);
> > +        function selectCommitsInRange(commit, index, allCommits) {
> > +            return index >= indexOfFirstRevision && index <= indexOfLastRevision;
> > +        }
> > +        var commits = this._commitsOnBranch(branchName, selectCommitsInRange.bind(this));
> > +        return commits;
> 
> And we can implement this as:
> 
> [...]
> return this._commitOnBranch(branchName, null, indexOfFirstRevision,
> indexOfLastRevision);
> 

err, I meant to write:

return this._commitsOnBranch(branchName, indexOfFirstRevision, indexOfLastRevision);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160203/9de0101b/attachment.html>