
<html>

    <head>

      <base href="https://bugs.webkit.org/" />

    </head>

    <body>

      <p>

        <div>

            <b><a class="bz_bug_link 

          bz_status_NEW "

   title="NEW - Teach dashboard code to compare non-integer revisions."

   href="https://bugs.webkit.org/show_bug.cgi?id=152345#c27">Comment # 27</a>

              on <a class="bz_bug_link 

          bz_status_NEW "

   title="NEW - Teach dashboard code to compare non-integer revisions."

   href="https://bugs.webkit.org/show_bug.cgi?id=152345">bug 152345</a>

              from <span class="vcard"><a class="email" href="mailto:dbates&#64;webkit.org" title="Daniel Bates &lt;dbates&#64;webkit.org&gt;"> <span class="fn">Daniel Bates</span></a>

</span></b>

        <pre>(In reply to <a href="show_bug.cgi?id=152345#c26">comment #26</a>)

<span class="quote">&gt; &gt; [...]

&gt; &gt; Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:82

&gt; &gt; +        var indexToBeLaterThan = this.indexOfRevision(revision);

&gt; &gt; +        function selectCommitsLaterThanRevision(commit, index, allCommits) {

&gt; &gt; +            return index &gt; indexToBeLaterThan;

&gt; &gt; +        }

&gt; &gt; +        var commits = this._commitsOnBranch(branchName, selectCommitsLaterThanRevision.bind(this));

&gt; &gt; +        return commits;

&gt; 

&gt; Then we can implement this as:

&gt; 

&gt; [...]

&gt; return this._commitsOnBranch(branchName, null, indexToBeLaterThan + 1);</span >


err, I meant to write:


return this._commitsOnBranch(branchName, indexToBeLaterThan + 1);


<span class="quote">&gt; 

&gt; &gt; Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:93

&gt; &gt; +        var indexOfFirstRevision = this.indexOfRevision(firstRevision);

&gt; &gt; +        var indexOfLastRevision = this.indexOfRevision(lastRevision);

&gt; &gt; +        function selectCommitsInRange(commit, index, allCommits) {

&gt; &gt; +            return index &gt;= indexOfFirstRevision &amp;&amp; index &lt;= indexOfLastRevision;

&gt; &gt; +        }

&gt; &gt; +        var commits = this._commitsOnBranch(branchName, selectCommitsInRange.bind(this));

&gt; &gt; +        return commits;

&gt; 

&gt; And we can implement this as:

&gt; 

&gt; [...]

&gt; return this._commitOnBranch(branchName, null, indexOfFirstRevision,

&gt; indexOfLastRevision);

&gt; </span >


err, I meant to write:


return this._commitsOnBranch(branchName, indexOfFirstRevision, indexOfLastRevision);</pre>

        </div>

      </p>

      <hr>

      <span>You are receiving this mail because:</span>

      
      <ul>

          <li>You are the assignee for the bug.</li>

      </ul>

    </body>

</html>