[Webkit-unassigned] [Bug 153361] AX: new lines in content editable elements don't notify accessibility

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153361

--- Comment #5 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 269595
  --> https://bugs.webkit.org/attachment.cgi?id=269595
patch.patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269595&action=review

> Source/WebCore/ChangeLog:10
> +        Post notifications when adding/removing a new line in content/editable

period after this sentence

> Source/WebCore/editing/AppendNodeCommand.cpp:57
> +        simpleNotifyAccessibilityForTextChange(m_node.ptr(), applyEditType());

simple is a strange prefix I feel. i think that could be dropped

> Source/WebCore/editing/CompositeEditCommand.cpp:438
> +        nodesToRemove.append(*node); 

unnecessary change

> Source/WebCore/editing/DeleteSelectionCommand.cpp:87
> +    , m_shouldSuppressAccessibilityNotifications(shouldSuppressAccessibilityNotifications)

i think the "should" can be dropped from all these names. doesn't seem to add much to the concept

> Source/WebCore/editing/EditCommand.h:117
> +    void simpleNotifyAccessibilityForTextChange(Node *, AXTextEditType);

* in wrong place

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160203/0dd2af6f/attachment.html>