<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: new lines in content editable elements don't notify accessibility"
href="https://bugs.webkit.org/show_bug.cgi?id=153361#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: new lines in content editable elements don't notify accessibility"
href="https://bugs.webkit.org/show_bug.cgi?id=153361">bug 153361</a>
from <span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=269595&action=diff" name="attach_269595" title="patch.patch">attachment 269595</a> <a href="attachment.cgi?id=269595&action=edit" title="patch.patch">[details]</a></span>
patch.patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=269595&action=review">https://bugs.webkit.org/attachment.cgi?id=269595&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:10
> + Post notifications when adding/removing a new line in content/editable</span >
period after this sentence
<span class="quote">> Source/WebCore/editing/AppendNodeCommand.cpp:57
> + simpleNotifyAccessibilityForTextChange(m_node.ptr(), applyEditType());</span >
simple is a strange prefix I feel. i think that could be dropped
<span class="quote">> Source/WebCore/editing/CompositeEditCommand.cpp:438
> + nodesToRemove.append(*node); </span >
unnecessary change
<span class="quote">> Source/WebCore/editing/DeleteSelectionCommand.cpp:87
> + , m_shouldSuppressAccessibilityNotifications(shouldSuppressAccessibilityNotifications)</span >
i think the "should" can be dropped from all these names. doesn't seem to add much to the concept
<span class="quote">> Source/WebCore/editing/EditCommand.h:117
> + void simpleNotifyAccessibilityForTextChange(Node *, AXTextEditType);</span >
* in wrong place</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>