[Webkit-unassigned] [Bug 153745] [GTK] Reduce IPC traffic due to view state changes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153745

Sergio Villar Senin <svillar at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #270390|review?                     |review+
              Flags|                            |

--- Comment #3 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 270390
  --> https://bugs.webkit.org/attachment.cgi?id=270390
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270390&action=review

Nice patch, although I think it doesn't really work as is (see my comment about the mask)

> Source/WebKit2/ChangeLog:27
> +        WebPageProxy::viewStateDidChange() and resret the flags that need

resret -> reset

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:316
> +        g_signal_connect(priv->toplevelOnScreenWindow, "window-state-event", G_CALLBACK(toplevelWindowStateEvent), webViewBase);

According to the docs you should enable GDK_STRUCTURE_MASK something that you are not doing. You should also remove the GDK_VISIBILITY_NOTIFY_MASK.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:1385
> +    unsigned flagsToUpdate = ViewState::IsFocused;

We could use ViewState::Flags here for consistency with the rest of the code (even though it's an unsigned anyway).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160203/a79e97cf/attachment.html>