<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:svillar@igalia.com" title="Sergio Villar Senin <svillar@igalia.com>"> <span class="fn">Sergio Villar Senin</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Reduce IPC traffic due to view state changes"
href="https://bugs.webkit.org/show_bug.cgi?id=153745">bug 153745</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #270390 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Reduce IPC traffic due to view state changes"
href="https://bugs.webkit.org/show_bug.cgi?id=153745#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Reduce IPC traffic due to view state changes"
href="https://bugs.webkit.org/show_bug.cgi?id=153745">bug 153745</a>
from <span class="vcard"><a class="email" href="mailto:svillar@igalia.com" title="Sergio Villar Senin <svillar@igalia.com>"> <span class="fn">Sergio Villar Senin</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=270390&action=diff" name="attach_270390" title="Patch">attachment 270390</a> <a href="attachment.cgi?id=270390&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=270390&action=review">https://bugs.webkit.org/attachment.cgi?id=270390&action=review</a>
Nice patch, although I think it doesn't really work as is (see my comment about the mask)
<span class="quote">> Source/WebKit2/ChangeLog:27
> + WebPageProxy::viewStateDidChange() and resret the flags that need</span >
resret -> reset
<span class="quote">> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:316
> + g_signal_connect(priv->toplevelOnScreenWindow, "window-state-event", G_CALLBACK(toplevelWindowStateEvent), webViewBase);</span >
According to the docs you should enable GDK_STRUCTURE_MASK something that you are not doing. You should also remove the GDK_VISIBILITY_NOTIFY_MASK.
<span class="quote">> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:1385
> + unsigned flagsToUpdate = ViewState::IsFocused;</span >
We could use ViewState::Flags here for consistency with the rest of the code (even though it's an unsigned anyway).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>