[Webkit-unassigned] [Bug 151992] [UNIX] Add support for windowless NPAPI plugins with no UI in non X11 platforms

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151992

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #270480|review?                     |review+
              Flags|                            |

--- Comment #10 from Darin Adler <darin at apple.com> ---
Comment on attachment 270480
  --> https://bugs.webkit.org/attachment.cgi?id=270480
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270480&action=review

While I’m not a platform expert I think I can review.

> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:534
> +            const auto& display = WebCore::PlatformDisplay::sharedDisplay();

I don’t think the const here is needed or helpful.

> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:537
> +            *reinterpret_cast<Display**>(value) = downcast<PlatformDisplayX11>(display).native();

Strange that the WebCore prefix is not needed here but is needed on the line above.

> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:56
>  class NetscapePluginStream;
> -    
> +#if PLUGIN_ARCHITECTURE(X11)
> +class NetscapePluginUnix;
> +#endif
>  class NetscapePlugin : public Plugin {

Please don’t delete the blank line here that separates the forward declarations from the class definition. Not clear that we need to put #if around a forward declaration. If we do, then please put it in a separate paragraph with spaces above and below the #if/#endif

> Source/WebKit2/WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.h:31
> +#include <WebCore/GraphicsContext.h>

I think we could use forward declarations for GraphicsContext and IntRect in this file rather than including the header, which is typically better.

> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:31
> +#if PLUGIN_ARCHITECTURE(X11)
> +#include "NetscapePluginUnix.h"

We normally put a blank line here between the #if and the #include.

> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:38
> +class NetscapePluginX11 final: public NetscapePluginUnix {

We normally put a space after final before ":".

> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:46
> +private:

We normally put a blank line here before private.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160203/48569502/attachment.html>