<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [UNIX] Add support for windowless NPAPI plugins with no UI in non X11 platforms"
href="https://bugs.webkit.org/show_bug.cgi?id=151992">bug 151992</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #270480 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [UNIX] Add support for windowless NPAPI plugins with no UI in non X11 platforms"
href="https://bugs.webkit.org/show_bug.cgi?id=151992#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [UNIX] Add support for windowless NPAPI plugins with no UI in non X11 platforms"
href="https://bugs.webkit.org/show_bug.cgi?id=151992">bug 151992</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=270480&action=diff" name="attach_270480" title="Updated patch">attachment 270480</a> <a href="attachment.cgi?id=270480&action=edit" title="Updated patch">[details]</a></span>
Updated patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=270480&action=review">https://bugs.webkit.org/attachment.cgi?id=270480&action=review</a>
While I’m not a platform expert I think I can review.
<span class="quote">> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:534
> + const auto& display = WebCore::PlatformDisplay::sharedDisplay();</span >
I don’t think the const here is needed or helpful.
<span class="quote">> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:537
> + *reinterpret_cast<Display**>(value) = downcast<PlatformDisplayX11>(display).native();</span >
Strange that the WebCore prefix is not needed here but is needed on the line above.
<span class="quote">> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:56
> class NetscapePluginStream;
> -
> +#if PLUGIN_ARCHITECTURE(X11)
> +class NetscapePluginUnix;
> +#endif
> class NetscapePlugin : public Plugin {</span >
Please don’t delete the blank line here that separates the forward declarations from the class definition. Not clear that we need to put #if around a forward declaration. If we do, then please put it in a separate paragraph with spaces above and below the #if/#endif
<span class="quote">> Source/WebKit2/WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.h:31
> +#include <WebCore/GraphicsContext.h></span >
I think we could use forward declarations for GraphicsContext and IntRect in this file rather than including the header, which is typically better.
<span class="quote">> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:31
> +#if PLUGIN_ARCHITECTURE(X11)
> +#include "NetscapePluginUnix.h"</span >
We normally put a blank line here between the #if and the #include.
<span class="quote">> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:38
> +class NetscapePluginX11 final: public NetscapePluginUnix {</span >
We normally put a space after final before ":".
<span class="quote">> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:46
> +private:</span >
We normally put a blank line here before private.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>