[Webkit-unassigned] [Bug 153768] Factor style sharing code out of StyleResolver

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 2 07:28:48 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=153768

--- Comment #8 from Ryosuke Niwa <rniwa at webkit.org> ---
(In reply to comment #7)
>
> > I got confused by this name because it sounded as if we need to do further
> > verification to make sure we can share a style with it.
> > How about "findStyleSharableElement" or "findElementToShareStyle"?
> 
> The class name is Style::SharingResolver so I feel "style" and "share" are
> redundant in the function name. I sort of like "similar" since it
> communicates why we can share style with it.

How about `findShared` or simply `resolve`?  I find the adjective `similar` to be more confusing because it sounds as if two elements share something but not identical in style.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160202/228ad1c5/attachment-0001.html>


More information about the webkit-unassigned mailing list