[Webkit-unassigned] [Bug 153768] Factor style sharing code out of StyleResolver

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153768

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #270435|review?                     |review+
              Flags|                            |

--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 270435
  --> https://bugs.webkit.org/attachment.cgi?id=270435
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270435&action=review

> Source/WebCore/style/StyleSharingResolver.cpp:65
> +static inline bool elementHasDirectionAuto(const Element& element)

Could take StyledElement& here, not that it would make things any faster.

> Source/WebCore/style/StyleTreeResolver.cpp:100
> +static RenderStyle* placeholderStyle;

Why is it OK if this is global, given that ensurePlaceholderStyle takes a document?

Also, extra blank line before this.

> Source/WebCore/style/StyleTreeResolver.cpp:976
> +bool isPlaceholderStyle(const RenderStyle& style)

Extra blank line before this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160202/1575acbc/attachment.html>