<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Factor style sharing code out of StyleResolver"
href="https://bugs.webkit.org/show_bug.cgi?id=153768">bug 153768</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #270435 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Factor style sharing code out of StyleResolver"
href="https://bugs.webkit.org/show_bug.cgi?id=153768#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Factor style sharing code out of StyleResolver"
href="https://bugs.webkit.org/show_bug.cgi?id=153768">bug 153768</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=270435&action=diff" name="attach_270435" title="patch">attachment 270435</a> <a href="attachment.cgi?id=270435&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=270435&action=review">https://bugs.webkit.org/attachment.cgi?id=270435&action=review</a>
<span class="quote">> Source/WebCore/style/StyleSharingResolver.cpp:65
> +static inline bool elementHasDirectionAuto(const Element& element)</span >
Could take StyledElement& here, not that it would make things any faster.
<span class="quote">> Source/WebCore/style/StyleTreeResolver.cpp:100
> +static RenderStyle* placeholderStyle;</span >
Why is it OK if this is global, given that ensurePlaceholderStyle takes a document?
Also, extra blank line before this.
<span class="quote">> Source/WebCore/style/StyleTreeResolver.cpp:976
> +bool isPlaceholderStyle(const RenderStyle& style)</span >
Extra blank line before this.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>