[Webkit-unassigned] [Bug 153624] Add code to parse the git branches out of the Trac RSS feed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153624

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #270448|review?                     |review+
              Flags|                            |

--- Comment #8 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 270448
  --> https://bugs.webkit.org/attachment.cgi?id=270448
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270448&action=review

> Tools/ChangeLog:3
> +        Add code to parse the git branches out of the Trac RSS feed.

Nit: Remove the period at the end of this line so that it reflects the name of this bug.

> Tools/ChangeLog:9
> +        (Trac.prototype.commitsOnBranch): Update filter to check for git branches.

Nit: git => Git

> Tools/ChangeLog:10
> +        (Trac.prototype._convertCommitInfoElementToObject): Parse git branches from the Trac RSS feed. Also changed "branchName" to

Ditto.

> Tools/ChangeLog:15
> +        fixture that contains XML with a git branch.

Ditto.

> Tools/ChangeLog:16
> +        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit test to test parsing git

Ditto.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:59
> +    strictEqual(commits.length, 3, "should have 2 commits");

2 => 3

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160202/37f86cb8/attachment-0001.html>