<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add code to parse the git branches out of the Trac RSS feed"
href="https://bugs.webkit.org/show_bug.cgi?id=153624">bug 153624</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #270448 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add code to parse the git branches out of the Trac RSS feed"
href="https://bugs.webkit.org/show_bug.cgi?id=153624#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add code to parse the git branches out of the Trac RSS feed"
href="https://bugs.webkit.org/show_bug.cgi?id=153624">bug 153624</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=270448&action=diff" name="attach_270448" title="Patch">attachment 270448</a> <a href="attachment.cgi?id=270448&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=270448&action=review">https://bugs.webkit.org/attachment.cgi?id=270448&action=review</a>
<span class="quote">> Tools/ChangeLog:3
> + Add code to parse the git branches out of the Trac RSS feed.</span >
Nit: Remove the period at the end of this line so that it reflects the name of this bug.
<span class="quote">> Tools/ChangeLog:9
> + (Trac.prototype.commitsOnBranch): Update filter to check for git branches.</span >
Nit: git => Git
<span class="quote">> Tools/ChangeLog:10
> + (Trac.prototype._convertCommitInfoElementToObject): Parse git branches from the Trac RSS feed. Also changed "branchName" to</span >
Ditto.
<span class="quote">> Tools/ChangeLog:15
> + fixture that contains XML with a git branch.</span >
Ditto.
<span class="quote">> Tools/ChangeLog:16
> + * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit test to test parsing git</span >
Ditto.
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:59
> + strictEqual(commits.length, 3, "should have 2 commits");</span >
2 => 3</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>