[Webkit-unassigned] [Bug 166356] New: WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=166356

            Bug ID: 166356
           Summary: WebKitTestRunner: Add comment to
                    TestRunner::setCanOpenWindows()
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: dbates at webkit.org
                CC: andersca at apple.com, ap at webkit.org,
                    lforschler at apple.com, sam at webkit.org

The remark in the patch for bug #43389 makes it unclear whether we should remove the test plugins/get-url-with-blank-target.html. Should we feel this test has value and want to keep it then we will need to implement testRunner.setCanOpenWindows() in WebKitTestRunner such that WebKitTestRunner forbids opening windows by default (this matches the behavior in DumpRenderTree). We should update the comment in TestRunner::setCanOpenWindows() to explain its purpose should we decide to keep the test plugins/get-url-with-blank-target.html.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161221/fa574399/attachment.html>