<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()"
href="https://bugs.webkit.org/show_bug.cgi?id=166356">166356</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>WebKit Nightly Build
</td>
</tr>
<tr>
<th>Hardware</th>
<td>All
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>Tools / Tests
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>dbates@webkit.org
</td>
</tr>
<tr>
<th>CC</th>
<td>andersca@apple.com, ap@webkit.org, lforschler@apple.com, sam@webkit.org
</td>
</tr></table>
<p>
<div>
<pre>The remark in the patch for <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Fix plug-in test failures and remove tests from the Skipped list"
href="show_bug.cgi?id=43389">bug #43389</a> makes it unclear whether we should remove the test plugins/get-url-with-blank-target.html. Should we feel this test has value and want to keep it then we will need to implement testRunner.setCanOpenWindows() in WebKitTestRunner such that WebKitTestRunner forbids opening windows by default (this matches the behavior in DumpRenderTree). We should update the comment in TestRunner::setCanOpenWindows() to explain its purpose should we decide to keep the test plugins/get-url-with-blank-target.html.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>