[Webkit-unassigned] [Bug 162124] op_get_by_id_with_this should use inline caching

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162124

--- Comment #52 from Caio Lima <ticaiolima at gmail.com> ---
View in context: https://bugs.webkit.org/attachment.cgi?id=296872&action=review

>> Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp:971
>> +                GPRReg baseForCustomGetGPR = baseGPR != thisGPR ? thisGPR : baseForGetGPR;
> 
> Is this corrects? Have you tested it?

I didn't create a test for that, however I think it is necessary. I'm going to double check that.

>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:264
>> +    if (spillMode == DontSpill) {
> 
> This should always be a constant for this function. Please remove and make it just baked into the code.

ok

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161221/b333e652/attachment.html>